scsi: hisi_sas: Fix NULL pointer dereference
authorGustavo A. R. Silva <gustavo@embeddedor.com>
Thu, 18 Oct 2018 16:59:39 +0000 (18:59 +0200)
committerSalvatore Bonaccorso <carnil@debian.org>
Thu, 18 Jul 2019 22:23:17 +0000 (23:23 +0100)
commit7e137287e4b5971dd7252a41ffaad51ba152517a
treeeb15dd6d5a2449641dcd12b7ed3d053642aa280f
parent9e26ce12ec88aedcd46b05545dfbd489285a7b18
scsi: hisi_sas: Fix NULL pointer dereference

There is a NULL pointer dereference in case *slot* happens to be NULL at
lines 1053 and 1878:

struct hisi_sas_cq *cq =
&hisi_hba->cq[slot->dlvry_queue];

Notice that *slot* is being NULL checked at lines 1057 and 1881:
if (slot), which implies it may be NULL.

Fix this by placing the declaration and definition of variable cq, which
contains the pointer dereference slot->dlvry_queue, after slot has been
properly NULL checked.

Addresses-Coverity-ID: 1474515 ("Dereference before null check")
Addresses-Coverity-ID: 1474520 ("Dereference before null check")
Fixes: 584f53fe5f52 ("scsi: hisi_sas: Fix the race between IO completion and timeout for SMP/internal IO")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Reviewed-by: Xiang Chen <chenxiang66@hisilicon.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Gbp-Pq: Topic bugfix/arm64/huawei-taishan
Gbp-Pq: Name 0032-scsi-hisi_sas-Fix-NULL-pointer-dereference.patch
drivers/scsi/hisi_sas/hisi_sas_main.c